feat(s3stream): wait for the background executor to close when shutting down the S3 storage #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng down the S3 storage Signed-off-by: SSpirits <admin@lv5.moe>
Chillax-0v0
reviewed
Jan 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #876 +/- ##
============================================
- Coverage 54.99% 54.97% -0.03%
+ Complexity 1246 1243 -3
============================================
Files 133 133
Lines 8535 8535
Branches 789 789
============================================
- Hits 4694 4692 -2
Misses 3426 3426
- Partials 415 417 +2
|
…ng down the S3 storage Signed-off-by: SSpirits <admin@lv5.moe>
Chillax-0v0
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.